Tell him it won't be so funny when you and your next husband are spending all his money

I used to get snide remarks behind my back about being a gold digger, when my husband started working on the oil rigs. No.
Remind him that you were there when he had nothing and YOU were the breadwinner. Remind him that even though he's got money now, he didn't when you fell in love. Cook a meal he used to eat when he was poor (you said spaghetti, ours used to be bangers and mash- wait, I still love bangers and mash) and tell him that when he jokes about you being a gold digger, it hurts and you don't like it. If he keeps persisting with it, you should consider leaving him. Or start making jokes about his little dick (or ugly dick, just something slightly emasculating) and see how he likes it.
There's nothing wrong with liking nice things. And there's nothing wrong with trying to support your family. He wanted kids (evidence: he stuck his dick in and got you pregnant), and a wife (evidence: he married you), so he needs to man up and do what he can to support you all (not saying it HAS to be financially, before any house husbands get offended, support can come in a variety of ways).

From what you have written here, I don't that your husband is being very fair. You earned your own money, you brought an investment property to the relationship. You gave up your career to have fulfill his need for children. It almost sounds like he is projecting his own insecurities of being poor when you met on to you. I don't think that anyting you can say is going to help unless he has counselling to help with his own insecurities. You could try speaking with him by using lots of "I "sentences ie I feel hurt when you say that I am with you just for the nice things. I would like to understand where this is coming from, you have said this a few times and I wuld like to know why you feel this way. Be prepared to listen.

Make a joke of it next time “yep, I thought someone living on 2 minute noodles must have had millions stashed somewhere!” Or “nope, you’re my toy boy, next husband will be the rich one” if you think he can take it in good humour. Or just tell him it bothers you and it’s bullshit - point out you brought more than him initially and his success since then is a reflection on your work as well - raising your kids,etc.

Although I might what you'd say have a history of being a gold digger because before him every man I ever dated I never loved, I liked them but I was quite selfish and more into being chased, wined and dined and given pretty things than falling in love.
I'd finished being chased and settled into just focusing on the family business doing 60 hour weeks and not thinking about men but living a life with very nice things.
Then I met him. A struggling 24 year old apprentice who lived off a diet of 2 minute noodles, bulk spaghetti and toast. (who doesn't love a good spaghetti lol)
I fell totally head over heals for him and supported him financially for the next few years until his apprenticeship ended and he got a better paying job and I had the baby.
I still very much like nice things although I don't like debt and don't have any bar what's left on my mortgage on our house and the small one on an investment property I got a few years before meeting him. I do like quality things. I'd rather 1 very nice handbag than for example 10 not so nice.
After 12 years of marriage after I stopped working to fullfil his "need to breed" he has provided me with a very happy life. I have not wanted for anything and he never says no to anything I want. He tends to show his love by buying me lovely things so ofcourse he gets allot of praise from that.
But then every so often he says he thinks I am only with him so that I have lots of nice things.
This is very silly. I would love him if he was very poor. I'd just go make my own money. Lol.
So what would you do in this situation?
It's getting quite annoying.
I don't know if he actually feels that way or if he just says it to be mean.
I love the fact he tries so hard to keep me happy, I love that he is a hard worker and wants the best for us but I also love him as a person. The best moments arent always spent when I've just been given something wonderful. Most are in the normal day to day experiences like snuggling in the morning or sitting on the deck reading a book on a hot day.
Perhaps he does generally feel I just love the nice house and nice car. Or maybe he's just being mean.

Sounds like you built what you have together apart from the investment property you bought to the relationship. Definitely not a gold digger in my opinion. If anyone is a gold digger I guess it's him since you supported him early on😂